Lunderberg commented on PR #14095: URL: https://github.com/apache/tvm/pull/14095#issuecomment-1445139232
Hmm. I think I'd still be worried on it, though mainly for naming reason. If I were encountering `implicit_padding=True` at the callsite as a first-time user, I would assume that the transformation is going to infer the shape of the transformed output, as opposed to disabling of a safety check. On the other hand, if I see something like `assume_injective_transform=True` or `unsafe_assume_injective_transform=True`, then it more clearly states that this is a precondition that must be guaranteed by the caller. Making this argument a keyword-only argument would also require the parameter name is present at the callsite, so the reader would see the parameter name and not just a lone `True`. That said, I'd still lean toward having the precondition checked by the transformation if at all possible. Is there a specific expression that is injective, but is failing to be recognized as such? If so, could we instead expand the analysis utilities to recognize the expression? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
