masahi commented on code in PR #14097:
URL: https://github.com/apache/tvm/pull/14097#discussion_r1116338447
##########
tests/python/relax/test_transform_fuse_ops_by_pattern.py:
##########
@@ -460,5 +496,10 @@ def test_multiple_calls_same_extern():
check(Conv2dx2, [("cutlass.conv2d", pat)], Conv2dx2_partitioned,
annoatate_codegen=True)
Review Comment:
So the purpose of using `dedup_params = false` is to decouple "duplication
check" and "param update" (the function is literally called
`CheckDefAndUpdateParam`). The only place where the function is called with
`dedup_params = true` is
https://github.com/apache/tvm/blob/46b500cb5eebfd2b75d7df97c009463cf4a75ca6/src/relax/transform/fuse_ops.cc#L402.
I just found that I can pass all tests even after removing this call.
So what we can do instead is to remove `dedup_params`, and rename
`CheckDefAndUpdateParams` to just `UpdateParams`, so that param deduplication
becomes the responsibility of the caller. I'll make such change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
