yelite commented on PR #14097: URL: https://github.com/apache/tvm/pull/14097#issuecomment-1445132329
In #14128 I created a generalized way (https://github.com/apache/tvm/pull/14128/files#diff-5abe4ef979258cbcc4927f057f939304de762c63c445137ba570689854c8f862R553-R569) to map args of the fused function to named parameters of the offloaded operation (for example, map arg1 -> "lhs", arg0 -> "rhs", arg2 -> "bias" for matmul). This requires each pattern to be accompanied by a map from string to DFPattern, like `{"lhs": pattern_lhs, "rhs": pattern_rhs}`, where each value of the map is a child pattern of the pattern that's used to fuse function. If we think the order of args and duplication of args is a common concern for all BYOC backends, but not for other use case of FuseOps, we should be able to extract that logic from #14128 and combine with the code in this PR to create a standalone pass for reordering and duplicate args. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
