adstraw commented on code in PR #14254:
URL: https://github.com/apache/tvm/pull/14254#discussion_r1140368645
##########
include/tvm/tir/builtin.h:
##########
@@ -726,15 +726,26 @@ TVM_DLL const Op& texture2d_store();
TVM_DLL const Op& texture2d_load();
/*!
- * \brief Initiate a non-blocking DMA copy from source to destination
+ * \brief Initiate a non-blocking DMA copy from source to destination; a DMA
copy outside of a group
+ * has a defacto group size of one
*/
TVM_DLL const Op& dma_copy();
/*!
- * \brief Wait until the number of DMAs in flight is less than or equal to
some maximum
+ * \brief Wait until the number of DMA groups in flight is less than or equal
to some maximum
*/
TVM_DLL const Op& dma_wait();
+/*!
Review Comment:
Similarly, I ended up with this:
```
/*!
* \brief Start a group of DMA copies
*
* Any call to `dma_copy()` that occurs after `dma_start_group()` will
* be added to the current group for tracking.
*
* Only one DMA group may be active at a given time. Calling
* `dma_start_group()` while a group is already active is unsupported.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
