adstraw commented on code in PR #14254:
URL: https://github.com/apache/tvm/pull/14254#discussion_r1140387258
##########
include/tvm/tir/builtin.h:
##########
@@ -726,15 +726,26 @@ TVM_DLL const Op& texture2d_store();
TVM_DLL const Op& texture2d_load();
/*!
- * \brief Initiate a non-blocking DMA copy from source to destination
+ * \brief Initiate a non-blocking DMA copy from source to destination; a DMA
copy outside of a group
+ * has a defacto group size of one
*/
TVM_DLL const Op& dma_copy();
/*!
- * \brief Wait until the number of DMAs in flight is less than or equal to
some maximum
+ * \brief Wait until the number of DMA groups in flight is less than or equal
to some maximum
*/
TVM_DLL const Op& dma_wait();
+/*!
+ * \brief Start a group of DMA copies
+ */
+TVM_DLL const Op& dma_start_group();
+
+/*!
Review Comment:
```
/*!
* \brief End a group of DMA copies
*
* Track all calls to `dma_copy()` that occurred since the preceding
* `dma_start_group()` as a single group in-flight.
*
* Calling `dma_end_group()` without an active group is unsupported.
*
* Note: A group of DMA calls may be empty, and will still contribute
* to the count of in-flight groups used by `dma_wait()`.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
