wrongtest-intellif commented on PR #14021:
URL: https://github.com/apache/tvm/pull/14021#issuecomment-1477243854
> 1. Since this pass can now be applied to the lowered TIR, would this allow
for de-duplication between the S-TIR lowering path and TE lowering path?
I remove the legacy check, let's see if there are issues in testing.
Generally, since the pass is after storage flatten for te codepath, I expect
there would be no special IR form to cause problems.
> 2. Are the `DeclBuffer` nodes sufficient to find all buffer declaration
locations? @vinx13 can correct me, but last I heard they weren't fully used
across the lowering flow.
The change is refactored to not depend on `DeclBuffer` nodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
