wrongtest-intellif commented on PR #14021: URL: https://github.com/apache/tvm/pull/14021#issuecomment-1501941327
Here lists lessons from te workloads: - There may exist opaque usage to the var before we meet any buffers, so a pre-collection `var2buffer_` is added to ensure we can treat the opaque access as full region access to the corresponding buffer. If the aliased buffer count > 1, we would skip the region collection and the buffers would not get mutated. - The itervar of thread binding from te-workloads would have empty `dom` field. - There would be conditions with non-bool type. Thus we add some normalization from `if(x: int32)` to `if (x != 0)` for non-bool conditions. - There would be mismatch from allocation dtype and buffer dtype, even if the buffer is the only one who refer to the allocated var. - The inferred region extent could be data dependent (for example, dependent by the buffer value `Y = T.allocate([X[i], ...)`, in such cases, we should not compact the buffer to the dynamic extent, just like in the loop-dependent allocation cases. Now it seems ok to the CI cases. Now we could disable the process for workloads from TE again and just leave some more covering cases for them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
