wrongtest-intellif commented on code in PR #14021: URL: https://github.com/apache/tvm/pull/14021#discussion_r1148250138
########## include/tvm/tir/transform.h: ########## @@ -437,10 +437,11 @@ TVM_DLL Pass ConvertBlocksToOpaque(); * * \endcode * - * + * \param is_strict ensure the compacted shape always smaller than the original shape. + * otherwise it allows to grow the shape to match actual accessed buffer regions. * \return The pass. */ -TVM_DLL Pass CompactBufferAllocation(); +TVM_DLL Pass CompactBufferAllocation(bool is_strict = true); Review Comment: Emmmm I am preferring to use it as a parameter since we are planning to use it multiple times under the same context., like - In phase0: standard compaction same with the mainline - In following phases : configure it as non-strict to adjust buffer regions after we enlarge or align loop domains to match certain hardware constraints. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
