FranklandJack commented on code in PR #14483:
URL: https://github.com/apache/tvm/pull/14483#discussion_r1158210582
##########
src/target/parsers/aprofile.cc:
##########
@@ -126,9 +127,8 @@ static TargetFeatures GetFeatures(TargetJSON target) {
bool has_dotprod = (dotprod_default && !dotprod_disable) || (dotprod_support
&& dotprod_flag);
return {
- {"is_aarch64", Bool(is_aarch64)},
- {"has_asimd", Bool(has_asimd)},
- {"has_dotprod", Bool(has_dotprod)},
+ {"is_aarch64", Bool(is_aarch64)}, {"has_asimd", Bool(has_asimd)},
+ {"has_sve", Bool(has_sve)}, {"has_dotprod", Bool(has_dotprod)},
Review Comment:
Good shout, I've added a test for this
[here](https://github.com/apache/tvm/pull/14483/files#diff-66ebf57fcac747725f36ace0cce2bb5d097bc6b3d3a6c225f6a367b4fb23ff08R293).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
