FranklandJack commented on code in PR #14483:
URL: https://github.com/apache/tvm/pull/14483#discussion_r1158811571
##########
src/target/parsers/aprofile.cc:
##########
@@ -112,6 +112,7 @@ static TargetFeatures GetFeatures(TargetJSON target) {
bool simd_flag = HasFlag(mcpu, mattr, "+neon") || HasFlag(mcpu, mattr,
"+simd");
bool has_asimd = is_aarch64 || simd_flag;
+ const auto has_sve = HasFlag(mcpu, mattr, "+sve");
Review Comment:
I take your point on `auto` but I'm not convinced this shouldn't be `const`
just to be consistent with the surrounding code when we could quite easily
update all the variables here to be `const` as part of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
