yongwww commented on PR #14394: URL: https://github.com/apache/tvm/pull/14394#issuecomment-1500573652
I feel call_pure_packed is a little weird for calling PrimFunc. It seems to me that `call_pure_external` is solely used for ExternFunc. Perhaps we can keep it as call_pure if we don't have a better name, and change it whenever we get a better name proposal. The `R.function(pure=False)` looks fine to me, and yes I think the entry is the right place for it. Feel free to leave a todo for me if that doesn't work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
