slyubomirsky commented on code in PR #14394:
URL: https://github.com/apache/tvm/pull/14394#discussion_r1162135912
##########
src/relax/op/op.cc:
##########
@@ -177,7 +227,9 @@ TVM_REGISTER_OP("relax.call_builtin_with_ctx")
.set_num_inputs(4)
.add_argument("func", "Expr", "The builtin packed func.")
.add_argument("args", "Tuple", "The input arguments.")
- .set_attr<FInferStructInfo>("FInferStructInfo",
InferStructInfoCallBuiltinWithCtx);
+ .set_attr<FInferStructInfo>("FInferStructInfo",
InferStructInfoCallBuiltinWithCtx)
+ // TODO(relax-team): Please verify if these are normally impure or not
Review Comment:
I noticed that there are builtins for updating a key-value store (those
related to the `attention_kv_cache`). Updates are not pure, so that's a
counterexample
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
