maekawatoshiki commented on code in PR #14536:
URL: https://github.com/apache/tvm/pull/14536#discussion_r1162350168


##########
tests/python/relay/test_pass_fake_quantization_to_integer.py:
##########
@@ -1114,5 +1114,36 @@ def test_fake_quantize_take():
     compare_fq_to_int(op, [x_np])
 
 
+def test_fake_quantize_softmax():

Review Comment:
   > 2. Play with QNN parameters (zero point, scale) in a such way that output 
from quantize will be in the range [-100, +100] for example. Not only "-128" 
like now
   
   I'm not sure why we need to modify QNN parameters (of `qnn.quantize`).
   I think that it's enough to change the value range specified in `x_np = 
np.random.randint(-128, 127, ...)` to satisfy the `qnn.quantize` output to be 
in the range of [-100, +100].
   (Sorry if my understanding is wrong)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to