maekawatoshiki commented on code in PR #14536:
URL: https://github.com/apache/tvm/pull/14536#discussion_r1162356413
##########
tests/python/relay/test_pass_fake_quantization_to_integer.py:
##########
@@ -1114,5 +1114,36 @@ def test_fake_quantize_take():
compare_fq_to_int(op, [x_np])
+def test_fake_quantize_softmax():
Review Comment:
> P.S.
I have checked output after qnn.quantize and see that some of value have
diff by 7. I think it is too much and the accuracy is unsatisfactory... any
thoughts?
In case all computation performed in integer-only arithmetic, how big diff
is allowed for `softmax` operation generally? I'm not sure about this.
I'm also not sure if any other algorithms outperform the current
implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
