tqchen commented on code in PR #14665:
URL: https://github.com/apache/tvm/pull/14665#discussion_r1171622886
##########
include/tvm/ir/source_map.h:
##########
@@ -127,6 +127,31 @@ class Span : public ObjectRef {
TVM_DEFINE_OBJECT_REF_METHODS(Span, ObjectRef, SpanNode);
};
+class MultiSpanNode : public SpanNode {
+ public:
+ Map<Span, ObjectRef> spans;
Review Comment:
Putting the object itself is more of an anti-pattern. You can however put in
more string information into the fused span. Ideally span should not refer back
to the IR fragement, this can cause things like cylic deps and other bad issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
