areusch commented on PR #14665: URL: https://github.com/apache/tvm/pull/14665#issuecomment-1526797435
i understand your point and that you're proposing a workable solution, but you haven't addressed the drawback of that solution which is that there's no forcing function to ensure that passes which run after this one also adjust the tracking information placed in the IR. i understand the proposed solution doesn't impact the IR, but it also makes it easier for the tracking info to grow stale. so I'm not really sure I see your proposed solution as strictly better--it has some drawbacks as well. I discussed this specific issue with @tqchen prior to creating this PR and he indicated he preferred such tracking info be confined in Span rather than placed elsewhere. we don't have to accept that decision unilaterally...but...at this point i don't really have bandwidth to redo this PR right now the way you want it. i guess we may not need it for a bit, so i'll just close it for now and we can come back to it when there's bandwidth. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
