masahi commented on code in PR #14792:
URL: https://github.com/apache/tvm/pull/14792#discussion_r1187021774
##########
src/runtime/opencl/opencl_module.cc:
##########
@@ -108,7 +109,27 @@ class OpenCLWrappedFunc {
LaunchParamConfig launch_param_config_;
};
-OpenCLModuleNode::~OpenCLModuleNode() {
+class OpenCLSPIRVModuleNode : public OpenCLModuleNodeBase {
Review Comment:
This class is still specific to OpenCL. Other than the input binary format
and kernel initialization, most runtime code are shared between the normal
OpenCL runtime and the new one that consumes SPIRV. So I want to put it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
