echuraev commented on code in PR #14792:
URL: https://github.com/apache/tvm/pull/14792#discussion_r1187033774
##########
src/runtime/opencl/opencl_module.cc:
##########
@@ -108,7 +109,27 @@ class OpenCLWrappedFunc {
LaunchParamConfig launch_param_config_;
};
-OpenCLModuleNode::~OpenCLModuleNode() {
+class OpenCLSPIRVModuleNode : public OpenCLModuleNodeBase {
Review Comment:
Probably in this case, `SPIRVShader` from Vulcan can be moved to OpenCL
directory? And I'm ok if it is in the same files with OpenCL runtime. Just as
an idea, probably the SPIRV part can be moved to new files such as
`spirv_module.h/cc`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
