masahi commented on code in PR #14574: URL: https://github.com/apache/tvm/pull/14574#discussion_r1197454928
########## src/ir/si_builder.cc: ########## @@ -0,0 +1,341 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file tvm/ir/si_builder.cc + * \brief Implementation for building a source info during rewriting expressions. + */ +#include <tvm/ir/si_builder.h> +#include <tvm/ir/transform.h> +#include <tvm/tir/stmt_functor.h> + +#include <vector> + +namespace tvm { + +using RelayExprSet = std::unordered_set<relay::Expr, ObjectPtrHash, ObjectPtrEqual>; +using PrimExprSet = std::unordered_set<PrimExpr, ObjectPtrHash, ObjectPtrEqual>; +using StmtSet = std::unordered_set<tir::Stmt, ObjectPtrHash, ObjectPtrEqual>; + +class RelayCollapse : public relay::ExprVisitor { + public: + explicit RelayCollapse(const RelayExprSet& inputs = {}) : inputs_(inputs) {} + + Span Collapse(const relay::Expr& entry); + + void VisitExpr(const relay::Expr& expr) final; + + private: + Array<Span> spans_; + const RelayExprSet& inputs_; +}; + +void RelayCollapse::VisitExpr(const relay::Expr& expr) { + if (visit_counter_.count(expr.get())) { + return; + } + if (expr->span.defined()) { + spans_.push_back(expr->span); + } + if (inputs_.find(expr) != inputs_.end()) { + // becuase it returns directly, it should be recorded as visted manually. + visit_counter_.insert({expr.get(), 1}); + return; + } + relay::ExprVisitor::VisitExpr(expr); +} + +Span RelayCollapse::Collapse(const relay::Expr& entry) { + VisitExpr(entry); + return SequentialSpan(spans_); +} + +class RelayRecursivelyFill : public relay::ExprMutator { + public: + explicit RelayRecursivelyFill(const Span& span, const RelayExprSet& inputs = {}) + : span_(span), inputs_(inputs) {} + + void Fill(const relay::Expr& entry); + + relay::Expr VisitExpr(const relay::Expr& expr) final; + + private: + const Span& span_; + const RelayExprSet& inputs_; +}; + +relay::Expr RelayRecursivelyFill::VisitExpr(const relay::Expr& expr) { + if (inputs_.find(expr) != inputs_.end()) { + return expr; + } + // Skip op node. Align with python frontend + if (!expr.as<OpNode>()) { + expr->span = span_; + } + + return relay::ExprMutator::VisitExpr(expr); +} + +void RelayRecursivelyFill::Fill(const relay::Expr& entry) { Mutate(entry); } + +class TirCollapse : public tir::StmtExprVisitor { + public: + explicit TirCollapse(const PrimExprSet& expr_inputs = {}, const StmtSet& stmt_inputs = {}) + : expr_inputs_(expr_inputs), stmt_inputs_(stmt_inputs) {} + + void VisitExpr(const PrimExpr& expr) final; + void VisitStmt(const tir::Stmt& stmt) final; + + bool IsInput(const PrimExpr& expr); + bool IsInput(const tir::Stmt& stmt); + + Span Collapse(const PrimExpr& expr); + Span Collapse(const tir::Stmt& stmt); + + private: + Array<Span> spans_; + std::unordered_map<const Object*, size_t> visit_counter_; + const PrimExprSet& expr_inputs_; + const StmtSet& stmt_inputs_; +}; + +Span TirCollapse::Collapse(const PrimExpr& expr) { + operator()(expr); + return SequentialSpan(spans_); +} + +Span TirCollapse::Collapse(const tir::Stmt& stmt) { + operator()(stmt); + return SequentialSpan(spans_); +} + +bool TirCollapse::IsInput(const PrimExpr& expr) { + return expr_inputs_.find(expr) != expr_inputs_.end(); +} + +bool TirCollapse::IsInput(const tir::Stmt& stmt) { + return stmt_inputs_.find(stmt) != stmt_inputs_.end(); +} + +void TirCollapse::VisitExpr(const PrimExpr& expr) { + if (visit_counter_.count(expr.get())) { + return; + } + if (expr->span.defined()) { + spans_.push_back(expr->span); + } + if (IsInput(expr)) { + // becuase it returns directly, it should be recorded as visted manually. + visit_counter_.insert({expr.get(), 1}); + return; + } + StmtExprVisitor::VisitExpr(expr); +} + +void TirCollapse::VisitStmt(const tir::Stmt& stmt) { + if (visit_counter_.count(stmt.get())) { + return; + } + if (stmt->span.defined()) { + spans_.push_back(stmt->span); + } + if (IsInput(stmt)) { + // becuase it returns directly, it should be recorded as visted manually. + visit_counter_.insert({stmt.get(), 1}); + return; + } + StmtExprVisitor::VisitStmt(stmt); +} + +class TirRecursivelyFill : public tir::StmtExprMutator { + public: + TirRecursivelyFill(const Span& span, const PrimExprSet& expr_inputs = {}, + const StmtSet& stmt_inputs = {}) + : span_(span), expr_inputs_(expr_inputs), stmt_inputs_(stmt_inputs) {} + + tir::Stmt Fill(const tir::Stmt& s) { return operator()(s); } + PrimExpr Fill(const PrimExpr& e) { return operator()(e); } + + bool IsInput(const PrimExpr& expr); + bool IsInput(const tir::Stmt& stmt); + + PrimExpr VisitExpr(const PrimExpr& expr) final; + tir::Stmt VisitStmt(const tir::Stmt& stmt) final; + + private: + const Span& span_; + const PrimExprSet& expr_inputs_; + const StmtSet& stmt_inputs_; +}; + +tir::Stmt TirRecursivelyFill::VisitStmt(const tir::Stmt& stmt) { + if (IsInput(stmt)) { + return stmt; + } + stmt->span = span_; + return StmtExprMutator::VisitStmt(stmt); +} + +bool TirRecursivelyFill::IsInput(const PrimExpr& expr) { + return expr_inputs_.find(expr) != expr_inputs_.end(); +} + +bool TirRecursivelyFill::IsInput(const tir::Stmt& stmt) { + return stmt_inputs_.find(stmt) != stmt_inputs_.end(); +} + +PrimExpr TirRecursivelyFill::VisitExpr(const PrimExpr& expr) { + if (IsInput(expr)) { + return expr; + } + expr->span = span_; + return StmtExprMutator::VisitExpr(expr); +} + +struct SIBuilder::Impl { + virtual Span CreateSpan() const = 0; + virtual void RecursivelyFillSpan(const relay::Expr& entry, const RelayExprSet& inputs) const = 0; + virtual void RecursivelyFillSpan(const PrimExpr& entry, const PrimExprSet& inputs) const = 0; + virtual void RecursivelyFillSpan(const tir::Stmt& entry, const PrimExprSet& inputs) const = 0; + virtual void RecursivelyFillSpan(const tir::Stmt& entry, const StmtSet& inputs) const = 0; + virtual void CollapseSpan(const relay::Expr& entry, const RelayExprSet& inputs) = 0; + virtual void CollapseSpan(const PrimExpr& entry, const PrimExprSet& inputs) = 0; + virtual void CollapseSpan(const tir::Stmt& entry, const PrimExprSet& inputs) = 0; + virtual void CollapseSpan(const tir::Stmt& entry, const StmtSet& inputs) = 0; +}; + +SIBuilder::~SIBuilder() = default; + +Span SIBuilder::CreateSpan() const { return impl_->CreateSpan(); } + +template <> +void SIBuilder::RecursivelyFillSpan(const relay::Expr& entry, const RelayExprSet& inputs) const { + impl_->RecursivelyFillSpan(entry, inputs); +} + +template <> +void SIBuilder::RecursivelyFillSpan(const PrimExpr& entry, const PrimExprSet& inputs) const { + impl_->RecursivelyFillSpan(entry, inputs); +} + +void SIBuilder::RecursivelyFillSpan(const tir::Stmt& entry, const PrimExprSet& inputs) const { + impl_->RecursivelyFillSpan(entry, inputs); +} + +void SIBuilder::RecursivelyFillSpan(const tir::Stmt& entry, const StmtSet& inputs) const { + impl_->RecursivelyFillSpan(entry, inputs); +} + +std::unique_ptr<SIBuilder::Impl> SIBuilder::CreateImpl(const Span& span) { + struct NullImpl : public SIBuilder::Impl { Review Comment: Yes, 2. is what I meant by "checking early". If that ends up with too-much repetitive check, I'm ok with your solution of making `NullImpl` a base class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
