junrushao commented on PR #14574:
URL: https://github.com/apache/tvm/pull/14574#issuecomment-1575335623
This PR introduces a potential issue as suggested by clang, which we might
want to patch:
```
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk/usr/include/c++/v1/__memory/unique_ptr.h:48:5:
warning: delete called on non-final 'tvm::SIBuilder::Impl' that has virtual
functions but non-virtual destructor [-Wdelete-non-abstract-non-virtual-dtor]
delete __ptr;
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk/usr/include/c++/v1/__memory/unique_ptr.h:305:7:
note: in instantiation of member function
'std::default_delete<tvm::SIBuilder::Impl>::operator()' requested here
__ptr_.second()(__tmp);
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk/usr/include/c++/v1/__memory/unique_ptr.h:259:19:
note: in instantiation of member function
'std::unique_ptr<tvm::SIBuilder::Impl>::reset' requested here
~unique_ptr() { reset(); }
^
/Users/jshao/Projects/tvm-dev/src/ir/si_builder.cc:229:12: note: in
instantiation of member function
'std::unique_ptr<tvm::SIBuilder::Impl>::~unique_ptr' requested here
SIBuilder::~SIBuilder() = default;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
