tqchen commented on code in PR #14972:
URL: https://github.com/apache/tvm/pull/14972#discussion_r1209310707
##########
tests/python/unittest/test_target_codegen_opencl.py:
##########
@@ -150,50 +158,38 @@ def check_type_casting(ctx, n, dtype):
tvm.tir.all(
*[
i // block_size == tvm.tir.const(3, "int32"),
- i % block_size == tvm.tir.const(3, "int32"),
Review Comment:
i also migrated the original test to the latest TensorIR so the test is
future proof.
Interestingly TensorIR becomes smarter :) so the original condition get
simplified and becomes `i == 15` here. So I modified the test to ensure we
cover most behavior we intend to cover around type casting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
