tqchen commented on code in PR #14972:
URL: https://github.com/apache/tvm/pull/14972#discussion_r1209312501


##########
tests/python/unittest/test_target_codegen_opencl.py:
##########
@@ -150,50 +158,38 @@ def check_type_casting(ctx, n, dtype):
                 tvm.tir.all(
                     *[
                         i // block_size == tvm.tir.const(3, "int32"),
-                        i % block_size == tvm.tir.const(3, "int32"),

Review Comment:
   Unfortunately relying on string pattern was too reliable given the set of 
possible transformations here. So we need to adapt the testcase as we go. If 
there is a new test cases in TVMScript, i think we can also put it here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to