slyubomirsky commented on code in PR #15171:
URL: https://github.com/apache/tvm/pull/15171#discussion_r1244390661
##########
tests/python/unittest/test_tir_lower_match_buffer.py:
##########
@@ -22,10 +22,10 @@
def _check(original, transformed):
- mod = tvm.IRModule.from_expr(original)
+ mod = tvm.IRModule.from_expr(original.with_attr("global_symbol", "main"))
Review Comment:
Should `from_expr` include a global symbol by default? The only reason I
hesitated on implementing that is because Relay and Relax also use `from_expr`
and I didn't want to mess with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
