slyubomirsky commented on code in PR #15171:
URL: https://github.com/apache/tvm/pull/15171#discussion_r1245670433
##########
python/tvm/relax/block_builder.py:
##########
@@ -346,8 +351,12 @@ def emit_te(self, func: Callable, *args: Any, **kwargs:
Any) -> Var:
kwargs : Any, optional
The keyword arguments passed to the function.
- Note that the key "primfunc_name_hint" is reserved for passing
name hint
- to the PrimFunc that gets generated.
+ Note that the below keys are reserved:
+ * "primfunc_name_hint" is reserved for passing a name hint
+ to the PrimFunc that gets generated.
+ * "primfunc_public" is reserved for indicating whether the
Review Comment:
For emitting PrimFuncs from Relax, I assume private is the default we want.
Happy to do it the other way if that's desirable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
