quic-sanirudh commented on PR #15178: URL: https://github.com/apache/tvm/pull/15178#issuecomment-1612466213
With this PR, the `alloc_storage`'s `size` parameter seems to have 2 different meanings based on which allocator we use. In the existing allocators, size is always expected to be 1d and it means the actual bytes of storage. With nd-allocator, it represents the physical shape of the buffer, and size is calculated from that. This mostly came up because of the AllocDataSpace API doing a similar thing, but I think we might need to make it both represent shape, or both represent the size of allocation. In case of 2d, it'll be size of allocation for each physical dimension. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
