quic-sanirudh commented on code in PR #15178:
URL: https://github.com/apache/tvm/pull/15178#discussion_r1246676699
##########
include/tvm/runtime/relax_vm/memory_manager.h:
##########
@@ -71,6 +72,14 @@ class Allocator {
* \return A sized allocation in the form of a buffer.
*/
virtual Buffer Alloc(size_t nbytes, size_t alignment, DLDataType type_hint)
= 0;
+ /*! \brief Allocate a buffer given a size, alignment and type.
+ * \param ndim The number of dimension of allocated tensor.
+ * \param shape The shape of allocated tensor.
+ * \param type_hint A type hint to the allocator.
+ * \param mem_scope The memory scope of allocated tensor.
+ * \return A sized allocation in the form of a buffer.
+ */
+ virtual Buffer Alloc(int ndim, const int64_t* shape, DLDataType type_hint,
String mem_scope);
Review Comment:
Thanks, I've updated the API with `ShapeTuple`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
