quic-sanirudh commented on PR #15178: URL: https://github.com/apache/tvm/pull/15178#issuecomment-1614825166
> Thanks @quic-sanirudh , left some extra comments. Agree about your point about allocator convention. One idea is always use the AllocWithScope API and in the case of raw bytes, pass in dtype as the element. > > Once we make most allocator use that, then the set of changes can become reasonably minor, only need to ensure that we know a flat memory can be reused as more higher dimensional arrays Thanks for your reply @tqchen. I did not fully understand this point. Could you explain the point about passing in dtype as the element? This is about the `alloc_storage` API right? Are you suggesting that we can always take in the shape, and in case of a requirement to allocate raw bytes, we can use the dtype to compute it and pass that to `AllocDataSpace`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
