quic-sanirudh commented on PR #15178: URL: https://github.com/apache/tvm/pull/15178#issuecomment-1615855284
I've updated the PR to change alloc_storage to take shape. Right now, the `VMBuiltinLower` is updated so that `vm.alloc_storage` always allocates with size as shape and dtype as `uint8`. One thing to note is that AllocDataSpace takes a type_hint argument, but as far as I can tell, only opengl runtime needed that and so for now, passing in a different dtype to AllocDataSpace isn't going to hurt any backends, but we may want to fix it. I'm planning to do that in a follow-up PR where I change the `relax.memory.alloc_storage` builtin generated by StaticPlanBlockMemory pass is also updated to take in shape and generates it with proper dtype. This would also allow me to later extend it to perhaps do the memory planning on a different storage_scope and probably NDAllocation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
