leandron commented on code in PR #15226:
URL: https://github.com/apache/tvm/pull/15226#discussion_r1257919692
##########
docker/install/ubuntu2004_install_python_package.sh:
##########
Review Comment:
Generally I'm fine with the change, but would also like to see another PR
with test passing when using the temporary Docker images generated by this job.
##########
docker/install/ubuntu2004_install_python_package.sh:
##########
@@ -43,4 +43,5 @@ pip3 install --upgrade \
junitparser==2.4.2 \
six \
tornado \
- pytest-lazy-fixture
+ pytest-lazy-fixture \
+ git+https://github.com/jax-ml/[email protected]
Review Comment:
I think we should favour the usage of this package from Pypi, like other
platforms. I checked and the source package is there:
https://pypi.org/project/ml-dtypes/0.2.0/#files
Can we just move to a plain `ml_dtypes` type of dependency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
