leandron commented on code in PR #15226: URL: https://github.com/apache/tvm/pull/15226#discussion_r1259406204
########## docker/install/ubuntu2004_install_python_package.sh: ########## Review Comment: It's great you want to do the test and you are correct wrt tlcpack, however, if you check in the CI results box below, you'll see a `docker/pr-head`, which generated a set of temporary images and uploaded them to AWS ECR. This is the specific one for this job: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-docker/detail/PR-15226/4/pipeline Usually people will get those images and submit a new PR to test CI with the temporary images (e.g. `477529581014.dkr.ecr.us-west-2.amazonaws.com/ci_i386:PR-15226-c0454f162-4`, by updating https://github.com/apache/tvm/blob/main/ci/jenkins/docker-images.ini with the image names. The test PR can be closed as soon as it finishes successfully, then we merge this one. Other PRs in past did it and it is safer for us to push for better testing on Docker changes, as they take a long time to troubleshoot when we break them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
