makarandhinge commented on PR #698: URL: https://github.com/apache/wayang/pull/698#issuecomment-3958216249
Thank you @mspruc for the feedback! You’re right the current test only checks the SQL string generation and doesn’t actually verify execution. Right now it covers things like SQL generation with AND clauses and correct table and column names. We could improve it by running the generated SQL and checking the results, such as making sure the correct number of rows is returned, joins match properly (for example, order_id=1 and customer_id=100), and data from both tables is combined correctly. Would you like me to add a full integration test to validate execution and results? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
