makarandhinge commented on PR #698: URL: https://github.com/apache/wayang/pull/698#issuecomment-3983348437
Hi @mspruc , Thanks for pointing this out. I changed `List.of()` to `Arrays.asList()` while working on the SQL implementation because I wanted to align with how lists are being passed to Calcite APIs in other parts of the codebase (e.g., places where `Arrays.asList()` is used when interacting with `LogicalTableScan` and SQL generation utilities). My intention was to avoid any potential incompatibility with Calcite’s internal handling of lists (especially since Calcite relies heavily on Guava’s `ImmutableList` internally), and to stay consistent with the existing usage patterns in the SQL-related modules. That said, there is no strong technical constraint that strictly requires `Arrays.asList()` here. If `List.of()` is preferred (e.g., for immutability or modern Java style), I’m happy to revert those changes. Please let me know your preference and I’ll update the patch accordingly. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
