This is an automated email from the ASF dual-hosted git repository. sebb pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/whimsy.git
The following commit(s) were added to refs/heads/master by this push: new 1cceffd Clarify purpose of variable 1cceffd is described below commit 1cceffdf5eaad2ee7f152ba8eb2fbf7835602c91 Author: Sebb <s...@apache.org> AuthorDate: Sun Feb 10 21:26:23 2019 +0000 Clarify purpose of variable --- www/roster/models/committer.rb | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/www/roster/models/committer.rb b/www/roster/models/committer.rb index 035a66e..34f2733 100644 --- a/www/roster/models/committer.rb +++ b/www/roster/models/committer.rb @@ -69,17 +69,19 @@ class Committer response[:groups] = person.services response[:committer] = [] response[:podlings] = [] - committees = ASF::Committee.pmcs.map(&:name) + pmc_names = ASF::Committee.pmcs.map(&:name) # From CI podlings = ASF::Podling.current.map(&:id) + + # Add group names unless they are a PMC group person.groups.map(&:name).each do |group| - unless committees.include? group + unless pmc_names.include? group response[:groups] << group end end # Get project(member) details person.projects.map(&:name).each do |project| - if committees.include? project + if pmc_names.include? project # Don't show committer karma if person has committee karma unless response[:committees].include? project # LDAP project group