This is an automated email from the ASF dual-hosted git repository.
sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git
The following commit(s) were added to refs/heads/master by this push:
new ae2ccb6 Using wrong comparison; must use memberids i.e. ou=pmc
ae2ccb6 is described below
commit ae2ccb68907fb8322297a71edb73c9d4e3c7174e
Author: Sebb <[email protected]>
AuthorDate: Sun Feb 10 22:14:50 2019 +0000
Using wrong comparison; must use memberids i.e. ou=pmc
---
www/secretary/ldap-check.cgi | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/www/secretary/ldap-check.cgi b/www/secretary/ldap-check.cgi
index b57d5c7..87ac5f0 100755
--- a/www/secretary/ldap-check.cgi
+++ b/www/secretary/ldap-check.cgi
@@ -66,14 +66,17 @@ _html do
pm_um=[]
um_pm=[]
notc=[]
- if c=ASF::Committee[p.name] # we have PMC
+ # TODO to be removed soon
+ # Use hasLDAP? to check if the underlying ou=pmc group exists
+ if c=ASF::Committee[p.name] and c.hasLDAP? # we have PMC group
po=p.ownerids
- co=c.ownerids
+ co=c.memberids
po_co=po-co
co_po=co-po
notc += po.reject {|n| old.include? n}
notc += co.reject {|n| old.include? n}
end
+ # TODO likewise, only applies to historic groups
if u=ASF::Group[p.name] # we have the unix group
pm=p.memberids
um=u.memberids
