[
https://issues.apache.org/jira/browse/WICKET-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541922
]
Doug Leeper commented on WICKET-1149:
-------------------------------------
You are correct in that HttpServletResponse#encodeURL has nothing to do
URLEncoder.
However, what you are effectively doing is a URLEncoder.encode by replacing &
with &
http://www.yahoo.com?arg1=foo&arg2=bar
and
http://www.yahoo.com?arg1=foo&arg2=bar
do not equals the same HTTP request
Try this if you don't believe me:
http://finance.yahoo.com/q/cq?d=v1&s=javad+ibm
http://finance.yahoo.com/q/cq?d=v1&s=javad+ibm
> LocalizedImageResource not formatting parameters properly when using
> ResourceReference
> --------------------------------------------------------------------------------------
>
> Key: WICKET-1149
> URL: https://issues.apache.org/jira/browse/WICKET-1149
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta4, 1.3.0-rc1
> Reporter: Doug Leeper
> Priority: Critical
> Fix For: 1.3.0-rc2
>
>
> When using a ResourceReference, the resultant URL generated is not formatted
> properly when using more than one parameter.
> For example:
> Correct URL:
> http://localhost:8081/homeIQ/app/resources/homeiq.wicket.HomeIQApplication/modelPicture?thumbnail=true&maxHeight=100&maxWidth=100&id=1
> Incorrect URL: (generated by LocalizedResourceReference)
> http://localhost:8081/homeIQ/app/resources/homeiq.wicket.HomeIQApplication/modelPicture?thumbnail=true&maxHeight=100&maxWidth=100&id=1
> As can be seen, the & has been replaced with &. This is the result of
> the following code:
> tag.put("src",
> RequestCycle.get().getOriginalResponse().encodeURL(
> Strings.replaceAll(url, "&", "&")));
> It should be:
> tag.put("src",
> RequestCycle.get().getOriginalResponse().encodeURL(url);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
