[ 
https://issues.apache.org/jira/browse/WICKET-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553719
 ] 

Doug Leeper commented on WICKET-1149:
-------------------------------------

I totally disagree that this issue is resolved.

If I have use attribute maxHeight...to get it from the parameters, I have to do 
the following amp;maxHeight.

This should not happen.  I should use maxHeight to get the value.

I will produce a test case so you can see.

> LocalizedImageResource not formatting parameters properly when using 
> ResourceReference
> --------------------------------------------------------------------------------------
>
>                 Key: WICKET-1149
>                 URL: https://issues.apache.org/jira/browse/WICKET-1149
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta4, 1.3.0-rc1
>            Reporter: Doug Leeper
>            Assignee: Matej Knopp
>            Priority: Critical
>             Fix For: 1.3.0-rc3
>
>
> When using a ResourceReference, the resultant URL generated is not formatted 
> properly when using more than one parameter.  
> For example:
> Correct URL:
> http://localhost:8081/homeIQ/app/resources/homeiq.wicket.HomeIQApplication/modelPicture?thumbnail=true&maxHeight=100&maxWidth=100&id=1
> Incorrect URL: (generated by LocalizedResourceReference)
> http://localhost:8081/homeIQ/app/resources/homeiq.wicket.HomeIQApplication/modelPicture?thumbnail=true&maxHeight=100&maxWidth=100&id=1
> As can be seen, the & has been replaced with &.  This is the result of 
> the following code:
>               tag.put("src", 
> RequestCycle.get().getOriginalResponse().encodeURL(
>                       Strings.replaceAll(url, "&", "&")));
> It should be:
>               tag.put("src", 
> RequestCycle.get().getOriginalResponse().encodeURL(url);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to