[
https://issues.apache.org/jira/browse/WICKET-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544886
]
Eelco Hillenius commented on WICKET-1180:
-----------------------------------------
Yeah, I think this came from habit and different people working on it. I don't
think I would mind removing final from most if not all converters.
> Converters : final vs non final
> -------------------------------
>
> Key: WICKET-1180
> URL: https://issues.apache.org/jira/browse/WICKET-1180
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-rc1
> Reporter: Stephane Bailliez
> Priority: Minor
>
> I can understand the reason not to put anything extensible but then there is
> a consistency problem as in the converters:
> all converters are final except: DateConverter, SqlDateConverter,
> SqlTimeConverter, SqlTimestampConverter
> which then makes you wonder why the rest is actually final, DateConverter is
> obviously not final to support inherirtance by the sql* converter, so if we
> wanted to restrict it, the base class should have been abstract and the other
> final, but it really does not protect any significant api changes from the
> client as the code is not so complex that it deserves to do so
> For instance I wanted to subclass ZeroPaddingConverter to work around the
> null support and I realize it's final, so I basically end up copying the
> whole code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
