[
https://issues.apache.org/jira/browse/WICKET-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Ertl updated WICKET-1418:
-------------------------------
Attachment: wicket-1418-pertl.patch
I think first wrapping AbortExceptions and later on unwrapping them again is
wrong. The AbortException should just be passed up to the RequestProcessor and
then processed.
We certainly don't want exceptions like that:
RuntimeException
-> RuntimeException
-> AbortException
the RuntimeException around are just useless...
So I would not crawl up the stacktrace until we find an AbortException but just
catch and rethrow it to prevent it from being wrapped.
Patch included.
> org.apache.wicket.MarkupContainer swallows AbortException
> ---------------------------------------------------------
>
> Key: WICKET-1418
> URL: https://issues.apache.org/jira/browse/WICKET-1418
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Peter Ertl
> Assignee: Igor Vaynberg
> Attachments: bugtest.zip, wicket-1418-pertl.patch, wicket-patch
>
>
> MarkupContainer#onBeforeRenderChildren() will catch exceptions of type
> org.apache.wicket.AbortException and remap them to a WicketRuntimeException.
> This is obviously wrong.
> For example when throwing a RestartResponseException the exception will be
> remapped to WicketRuntimeException and the response will not be restarted but
> the error page will be shown.
> I attached a usecase to demonstrate this bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
