[
https://issues.apache.org/jira/browse/WICKET-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578366#action_12578366
]
Igor Vaynberg commented on WICKET-1418:
---------------------------------------
maybe we better take this to the list...i created a thread for this issue
there, but to answer your questions:
> What's the motivation behind wrapping AbortExceptions?
when that code was written there was no abortexception. also, most times, you
dont think about checking for it, just wrap and rethrow
> And, yes, this should indeed happen anywhere you catch RuntimeException...
if we never forget to do the check that would work :)
> Pass it, not wrap it
see above :)
> Otherwise you probably would have to change RequestCycle#step() in line 1256
> (current trunk) to unwrap AbortExceptions before processing them
i dont see why we would have to unwrap abort exceptions themselves....
> org.apache.wicket.MarkupContainer swallows AbortException
> ---------------------------------------------------------
>
> Key: WICKET-1418
> URL: https://issues.apache.org/jira/browse/WICKET-1418
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Peter Ertl
> Assignee: Igor Vaynberg
> Attachments: bugtest.zip, wicket-1418-pertl.patch, wicket-patch
>
>
> MarkupContainer#onBeforeRenderChildren() will catch exceptions of type
> org.apache.wicket.AbortException and remap them to a WicketRuntimeException.
> This is obviously wrong.
> For example when throwing a RestartResponseException the exception will be
> remapped to WicketRuntimeException and the response will not be restarted but
> the error page will be shown.
> I attached a usecase to demonstrate this bug.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
