[
https://issues.apache.org/jira/browse/WICKET-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892204#action_12892204
]
Martin Grigorov commented on WICKET-2719:
-----------------------------------------
Hi Maarten,
Here are my points:
* your attachment is not complete.
** you don't provide patches for all current implementations of IDataProvider
** even with patches the modification will probably go only in trunk. I don't
want to compromise 1.4.x.
** there are no tests. unit tests will convince me easier ;-)
Please provide the ones above and I'll reconsider them.
The current implementation is fully compatible with the previous one, it just
gives you the possibility to extend and modify it, make it lazy and this is the
actual request in this ticket. And for the default case (backed by a "final
List") calling getData() several times in one request doesn't hurt.
> Extract lazy AbstractListDataProvider out of ListDataProvider.
> --------------------------------------------------------------
>
> Key: WICKET-2719
> URL: https://issues.apache.org/jira/browse/WICKET-2719
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.5
> Reporter: Maarten Billemont
> Assignee: Martin Grigorov
> Fix For: 1.4.7, 1.5-M1
>
> Attachments: AbstractListProvider.java
>
>
> ListDataProvider is handy for quickly providing a List as source for a
> DataView; but it forces you to pass a list object during construction and
> doesn't allow you to provide a new list.
> That means it becomes hard to update the elements in the DataView when the
> page is (re)rendered. It might be useful to provide an abstract superclass
> to ListDataProvider which provides an abstract method for obtaining the list
> allowing the developer to lazy-load the data he wants to show; making sure to
> always load up-to-date data when the view is being rendered rather than data
> he passed in during construction which may have become outdated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
