[ 
https://issues.apache.org/jira/browse/WICKET-3577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014027#comment-13014027
 ] 

Martin Grigorov commented on WICKET-3577:
-----------------------------------------

In your patch I don't see any usages of these new methods.
Also we have org.apache.wicket.protocol.http.WicketURLEncoder which is a bit 
smarter than java.net.URLEncoder

> Escape invalid characters in a cookie
> -------------------------------------
>
>                 Key: WICKET-3577
>                 URL: https://issues.apache.org/jira/browse/WICKET-3577
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>    Affects Versions: 1.5-RC3
>            Reporter: Bertrand Guay-Paquet
>            Priority: Minor
>              Labels: cookie
>         Attachments: cookies.patch
>
>
> The proposed patch adds methods to CookieUtils to escape and un-escape a 
> string for invalid cookie characters.
> These methods should perhaps systematically be called when using the other 
> CookieUtils methods. However, this could potentially break cookies existing 
> prior to that change. On the other hand, CookieUtils has only just been added 
> in wicket 1.5 so maybe this isn't a problem.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to