[ 
https://issues.apache.org/jira/browse/WICKET-3577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014154#comment-13014154
 ] 

Bertrand Guay-Paquet commented on WICKET-3577:
----------------------------------------------

That is correct. The patch was submitted to show the starting point of the 
final patch, since I could't decide on whether cookies should be systematically 
escaped.

In 1.5, I couldn't find org.apache.wicket.protocol.http.WicketURLEncoder. Are 
you referring to org.apache.wicket.request.UrlEncoder?

I didn't know about that class when I created the issue; it would have saved me 
some time digging for information about encoding base64 content in a cookie! 

Anyway, the functionality is already there, please close this issue.

> Escape invalid characters in a cookie
> -------------------------------------
>
>                 Key: WICKET-3577
>                 URL: https://issues.apache.org/jira/browse/WICKET-3577
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>    Affects Versions: 1.5-RC3
>            Reporter: Bertrand Guay-Paquet
>            Priority: Minor
>              Labels: cookie
>         Attachments: cookies.patch
>
>
> The proposed patch adds methods to CookieUtils to escape and un-escape a 
> string for invalid cookie characters.
> These methods should perhaps systematically be called when using the other 
> CookieUtils methods. However, this could potentially break cookies existing 
> prior to that change. On the other hand, CookieUtils has only just been added 
> in wicket 1.5 so maybe this isn't a problem.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to