[
https://issues.apache.org/jira/browse/WICKET-3705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032702#comment-13032702
]
Peter Ertl commented on WICKET-3705:
------------------------------------
Allright, I see that the current coding is not satisfying...
I have several questions and would love to get some feedback:
1. form processing order:
this is the order of form processing in 1.4.x (outer to inner form):
// call onSubmit on nested forms
formToProcess.visitChildren(Form.class, new IVisitor<Form<?>>()
{
public Object component(Form<?> component)
{
Form<?> form = component;
if (form.isEnabledInHierarchy() &&
form.isVisibleInHierarchy())
{
form.onSubmit();
return IVisitor.CONTINUE_TRAVERSAL;
}
return
IVisitor.CONTINUE_TRAVERSAL_BUT_DONT_GO_DEEPER;
}
});
so do we really want to change that in 1.5 (inner to outer form) ?
2. in Martijn's case (= quickstart) the form visibility is changed during form
submit processing. Therefore the submitting component's onSubmit is called but
Form#onSubmit not since the submitting component hides the modal windows which
implicitly hides the contained form. Do we want that form visibility (and
enabled) state changes during submit processing affect subsequent processing?
3. is staying as close to 1.4.x processing as possible to make migration
seamless an issue?
> AjaxSubmit in modal window doesn't call form.onSubmit() before ending request
> -----------------------------------------------------------------------------
>
> Key: WICKET-3705
> URL: https://issues.apache.org/jira/browse/WICKET-3705
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core, wicket-extensions
> Affects Versions: 1.5-RC4
> Reporter: Martijn Dashorst
> Assignee: Peter Ertl
> Fix For: 1.5-RC5
>
> Attachments: myproject-1.4.tgz, myproject.tgz
>
>
> When a AjaxSubmitLink is used to submit a form inside a ModalWindow, and
> inside the AjaxSubmitLink#onSubmit() the window is closed, wicket doesn't
> call Form.onSubmit()
> See attached quickstart for the scenario.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
