[ 
https://issues.apache.org/jira/browse/WICKET-3705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034741#comment-13034741
 ] 

Pedro Santos edited comment on WICKET-3705 at 5/17/11 1:10 PM:
---------------------------------------------------------------

Sure, I noticed that I miss the involved complexity about state caching.

The same work around in 1.4 would have to be done in 1.5 because only reverse 
onsubmit() sequence is not enough for all use cases.

Mark a flag to trigger some action coded in onConfigure is a good user 
solution. What if we try to make clear that it's user responsibility to delay 
form processing sensitive changes to render phase? An possible improvement is 
this direction would be create the FormProcessing type that would be visible by 
all submit callbacks, and would provide an API do schedule post submit actions.
e.g.
add(new Button(){
  onSubmit(processing){
    //here code not involving interface like queries or data manipulation
    processing.schedule(new Action(){ 
rootForm.disableBecauseSomeDataReachedSomeState();});
  };
});

      was (Author: pedrosans):
    Sure, I noticed that I miss the involved complexit about state caching.

The same work around in 1.4 would have to be done in 1.5 because only reverse 
onsubmit() sequence is not enough for all usecases.

Mark a flag to trigger some action coded in onConfigure is a good user 
solution. What if we try to make clear that it's user responsability to delay 
form processing sensitive changes to render phase? An possible improvement is 
this direction would be create the FormProcessing type that woul be visible by 
all submit callbacks, and would provide an API do schedule post submit actions.
e.g.
add(new Button(){
  onSubmit(processing){
    //here code not involving interface like querys or data manimulatio
    processing.schedule(new Action(){ 
rootForm.disableBecauseSomeDataReachedSomeState();});
  };
});

  
> AjaxSubmit in modal window doesn't call form.onSubmit() before ending request
> -----------------------------------------------------------------------------
>
>                 Key: WICKET-3705
>                 URL: https://issues.apache.org/jira/browse/WICKET-3705
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core, wicket-extensions
>    Affects Versions: 1.5-RC4
>            Reporter: Martijn Dashorst
>            Assignee: Peter Ertl
>             Fix For: 1.5-RC5
>
>         Attachments: WICKET-3705.patch, myproject-1.4.tgz, myproject.tgz
>
>
> When a AjaxSubmitLink is used to submit a form inside a ModalWindow, and 
> inside the AjaxSubmitLink#onSubmit() the window is closed, wicket doesn't 
> call Form.onSubmit()
> See attached quickstart for the scenario.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to