[ 
https://issues.apache.org/jira/browse/WICKET-4019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099042#comment-13099042
 ] 

Peter Pastrnak commented on WICKET-4019:
----------------------------------------

The old one uses the "IRequestCodingStrategy", that works with pure String 
instead of the Url type. I had just about 3 days to make the old one running on 
 Wicket 1.5 and I could not find anything like RequestCodingStrategy, so I 
created a custom RequestMapper, that wraps the SystemMapper and modifies the 
URL depending on the RequestHandler. Its maybe not the best solution, but that 
was the only one I could find within very short time. Now its completely 
separated from wicket-core, you just have to subtype PortletApplication instead 
of WebApplication to let it initialize the request mapper, render strategy and 
a component initialization listener (to adapt the markup ids). 

> UrlEncoder - question mark not encoded in parameter values
> ----------------------------------------------------------
>
>                 Key: WICKET-4019
>                 URL: https://issues.apache.org/jira/browse/WICKET-4019
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Peter Pastrnak
>
> Url returned by the RequestMapper does not seem to be properly rendered, as 
> it does not encode question mark character in the Url parameter value (I 
> haven't checked the w3c spec, but at least Liferay Portal seems to require it 
> to be encoded) 
> The reason is this definition in the UrlEncoder: 
>                         case QUERY : 
>                                 // to allow direct passing of URL in query 
>                                 dontNeedEncoding.set('/'); 
>                                 // to allow direct passing of URL in query 
>                                 dontNeedEncoding.set('?'); 
> Currently URL "http://host/file?param=a?b"; would be encoded as 
> "http://host/file?param=a?b";, instead of "http://host/file?param=a%3Fb";

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to