[ 
https://issues.apache.org/jira/browse/WICKET-4019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105235#comment-13105235
 ] 

Peter Pastrnak commented on WICKET-4019:
----------------------------------------

Currently seems to be impossible for me to reserve more time for this. The 
earliest I could find some time for test cases is in December. If we find some 
bugs while developing our projects, I can submit patches, but currently not 
more.
>From what I remember, there are most probably some parts, that are not 
>necessary anymore (they were there because of Wicket 1.4 compatibility with 
>older versions), but I left them there, as I didn't have enough time to 
>investigate why were they there and if they can be safely removed. Also in 
>WicketFilter there is a 'hack' to access the application object, as I could 
>not find a way how to get to it. Hopefully I did not remove too much of the 
>old bridge and it will work on other portlet containers too. We use only 
>Liferay. Don't forget, that it won't work for other people using Liferay, if 
>you don't 'fix' the UrlRenderer issue. I haven't submitted a bug report to 
>them yet, as it would be good to test it with a newer version of Liferay first.

> UrlEncoder - question mark not encoded in parameter values
> ----------------------------------------------------------
>
>                 Key: WICKET-4019
>                 URL: https://issues.apache.org/jira/browse/WICKET-4019
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Peter Pastrnak
>         Attachments: wicket-portlet-1.5.RC7.zip
>
>
> Url returned by the RequestMapper does not seem to be properly rendered, as 
> it does not encode question mark character in the Url parameter value (I 
> haven't checked the w3c spec, but at least Liferay Portal seems to require it 
> to be encoded) 
> The reason is this definition in the UrlEncoder: 
>                         case QUERY : 
>                                 // to allow direct passing of URL in query 
>                                 dontNeedEncoding.set('/'); 
>                                 // to allow direct passing of URL in query 
>                                 dontNeedEncoding.set('?'); 
> Currently URL "http://host/file?param=a?b"; would be encoded as 
> "http://host/file?param=a?b";, instead of "http://host/file?param=a%3Fb";

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to