[ 
https://issues.apache.org/jira/browse/WICKET-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134849#comment-13134849
 ] 

Sverre Boschman commented on WICKET-4164:
-----------------------------------------

How did you test the performance of the map? My very naive approach of running 
the unittest a few times in eclipse and looking at the reported execution time 
of the heavyLoad test shows you actually made the performance better, not 
worse. The synchronized parts will block and decrease performance, but the 
maximum capacity of the underlying hashmap never grows beyond 1000. Which means 
a lot less very expensive rehashes.
                
> StoredResponsesMap not threadsafe
> ---------------------------------
>
>                 Key: WICKET-4164
>                 URL: https://issues.apache.org/jira/browse/WICKET-4164
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5.1
>            Reporter: Sverre Boschman
>         Attachments: WICKET-4164.patch
>
>
> The StoredResponsesMap is based on the not so threadsafe LinkedHashMap. This 
> map is filled from multiple threads by the WebPageRenderer, which can lead to 
> the internal table property of hashmap going out of sync with the header 
> property of linkedhashmap. As the hashmap entries are not gc'able this leads 
> to out of memory exceptions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to