Add 'jshint' to the default tasks. Fix some JSHint errors
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/6624e3de Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/6624e3de Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/6624e3de Branch: refs/heads/wicket-6.x Commit: 6624e3de1ec923cbb84371efa986bac5022bdbc9 Parents: 6816a40 Author: Martin Tzvetanov Grigorov <[email protected]> Authored: Mon Sep 30 22:39:49 2013 +0200 Committer: Martin Tzvetanov Grigorov <[email protected]> Committed: Mon Sep 30 22:39:49 2013 +0200 ---------------------------------------------------------------------- Gruntfile.js | 3 +-- wicket-core/src/test/js/event.js | 8 ++++---- .../ajax/markup/html/autocomplete/wicket-autocomplete.js | 8 ++++++-- .../extensions/ajax/markup/html/form/upload/progressbar.js | 2 +- .../apache/wicket/extensions/markup/html/tree/res/tree.js | 2 +- 5 files changed, 13 insertions(+), 10 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/6624e3de/Gruntfile.js ---------------------------------------------------------------------- diff --git a/Gruntfile.js b/Gruntfile.js index 127d429..cd47c7a 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -132,6 +132,5 @@ module.exports = function(grunt) { // This plugin provides the "connect" task - starts a web server for the Ajax tests. grunt.loadNpmTasks('grunt-contrib-connect'); - // A convenient task alias. - grunt.registerTask('test', ['connect', 'qunit']); + grunt.registerTask('default', ['jshint', 'connect', 'qunit']); }; http://git-wip-us.apache.org/repos/asf/wicket/blob/6624e3de/wicket-core/src/test/js/event.js ---------------------------------------------------------------------- diff --git a/wicket-core/src/test/js/event.js b/wicket-core/src/test/js/event.js index 17dc9ca..bb3cde5 100644 --- a/wicket-core/src/test/js/event.js +++ b/wicket-core/src/test/js/event.js @@ -15,7 +15,7 @@ * limitations under the License. */ -/*global ok: true, start: true, test: true, equal: true, deepEqual: true, +/*global ok: true, start: true, stop: true, test: true, equal: true, deepEqual: true, QUnit: true, module: true, expect: true */ jQuery(document).ready(function() { @@ -232,7 +232,7 @@ jQuery(document).ready(function() { Wicket.Event.publish(topic); Wicket.Event.unsubscribe(topic, subscriber); - ok(true, "The subscriber is un-subscribed") + ok(true, "The subscriber is un-subscribed"); Wicket.Event.publish(topic); }); @@ -256,7 +256,7 @@ jQuery(document).ready(function() { Wicket.Event.publish(topic); Wicket.Event.unsubscribe(topic); - ok(true, "The subscribers are un-subscribed") + ok(true, "The subscribers are un-subscribed"); Wicket.Event.publish(topic); }); @@ -280,7 +280,7 @@ jQuery(document).ready(function() { Wicket.Event.publish(topic); Wicket.Event.unsubscribe(); - ok(true, "The subscribers are un-subscribed") + ok(true, "The subscribers are un-subscribed"); Wicket.Event.publish(topic); }); http://git-wip-us.apache.org/repos/asf/wicket/blob/6624e3de/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js ---------------------------------------------------------------------- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js index 45e5fcf..2bdc5b2 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js @@ -359,7 +359,9 @@ var hasMinimumLength = elementVal.length >= minInputLength; var result = hasMinimumLength && activeIsInitial; - if (!result) hideAutoComplete(); + if (!result) { + hideAutoComplete(); + } return result; }], ep: {}, @@ -382,7 +384,9 @@ var elementVal = Wicket.$(elementId).value; var hasMinimumLength = elementVal.length >= minInputLength; var result = hasMinimumLength && activeIsInitial; - if (!result) hideAutoComplete(); + if (!result) { + hideAutoComplete(); + } return result; }], ep: {}, http://git-wip-us.apache.org/repos/asf/wicket/blob/6624e3de/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js ---------------------------------------------------------------------- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js index 9cdfb9e..b1defb5 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js @@ -19,7 +19,7 @@ 'use strict'; if (typeof(Wicket) === "undefined") { - Wicket = {}; + window.Wicket = {}; } Wicket.WUPB = Wicket.Class.create(); http://git-wip-us.apache.org/repos/asf/wicket/blob/6624e3de/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/res/tree.js ---------------------------------------------------------------------- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/res/tree.js b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/res/tree.js index b560599..a8b19d7 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/res/tree.js +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/tree/res/tree.js @@ -18,7 +18,7 @@ 'use strict'; if (typeof(Wicket) === "undefined") { - Wicket = {}; + window.Wicket = {}; } Wicket.Tree = {};
