Add 'jshint' to the default tasks. Fix some JSHint errors
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/599168c8 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/599168c8 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/599168c8 Branch: refs/heads/master Commit: 599168c8fa1a5c017d0e2eaa09e7823f7c171e3b Parents: 8b84a32 Author: Martin Tzvetanov Grigorov <[email protected]> Authored: Mon Sep 30 22:39:49 2013 +0200 Committer: Martin Tzvetanov Grigorov <[email protected]> Committed: Mon Sep 30 22:45:00 2013 +0200 ---------------------------------------------------------------------- Gruntfile.js | 3 +-- package.json | 2 +- wicket-core/src/test/js/event.js | 10 +++++----- .../ajax/markup/html/autocomplete/wicket-autocomplete.js | 8 ++++++-- .../ajax/markup/html/form/upload/progressbar.js | 2 +- 5 files changed, 14 insertions(+), 11 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/599168c8/Gruntfile.js ---------------------------------------------------------------------- diff --git a/Gruntfile.js b/Gruntfile.js index 127d429..cd47c7a 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -132,6 +132,5 @@ module.exports = function(grunt) { // This plugin provides the "connect" task - starts a web server for the Ajax tests. grunt.loadNpmTasks('grunt-contrib-connect'); - // A convenient task alias. - grunt.registerTask('test', ['connect', 'qunit']); + grunt.registerTask('default', ['jshint', 'connect', 'qunit']); }; http://git-wip-us.apache.org/repos/asf/wicket/blob/599168c8/package.json ---------------------------------------------------------------------- diff --git a/package.json b/package.json index 29e5a31..b6c0a4a 100644 --- a/package.json +++ b/package.json @@ -10,6 +10,6 @@ "grunt-contrib-nodeunit": "~0.2.1" }, "scripts": { - "test": "grunt test --verbose" + "test": "grunt --verbose" } } \ No newline at end of file http://git-wip-us.apache.org/repos/asf/wicket/blob/599168c8/wicket-core/src/test/js/event.js ---------------------------------------------------------------------- diff --git a/wicket-core/src/test/js/event.js b/wicket-core/src/test/js/event.js index b8535c8..e180b4f 100644 --- a/wicket-core/src/test/js/event.js +++ b/wicket-core/src/test/js/event.js @@ -15,8 +15,8 @@ * limitations under the License. */ -/*global ok: true, start: true, test: true, equal: true, deepEqual: true, - QUnit: true, module: true, expect: true, stop: true */ +/*global ok: true, start: true, stop: true, test: true, equal: true, deepEqual: true, + QUnit: true, module: true, expect: true */ jQuery(document).ready(function() { "use strict"; @@ -232,7 +232,7 @@ jQuery(document).ready(function() { Wicket.Event.publish(topic); Wicket.Event.unsubscribe(topic, subscriber); - ok(true, "The subscriber is un-subscribed") + ok(true, "The subscriber is un-subscribed"); Wicket.Event.publish(topic); }); @@ -256,7 +256,7 @@ jQuery(document).ready(function() { Wicket.Event.publish(topic); Wicket.Event.unsubscribe(topic); - ok(true, "The subscribers are un-subscribed") + ok(true, "The subscribers are un-subscribed"); Wicket.Event.publish(topic); }); @@ -280,7 +280,7 @@ jQuery(document).ready(function() { Wicket.Event.publish(topic); Wicket.Event.unsubscribe(); - ok(true, "The subscribers are un-subscribed") + ok(true, "The subscribers are un-subscribed"); Wicket.Event.publish(topic); }); http://git-wip-us.apache.org/repos/asf/wicket/blob/599168c8/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js ---------------------------------------------------------------------- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js index 51671a3..d465e1f 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js @@ -361,7 +361,9 @@ var hasMinimumLength = elementVal.length >= minInputLength; var result = hasMinimumLength && activeIsInitial; - if (!result) hideAutoComplete(); + if (!result) { + hideAutoComplete(); + } return result; }], ep: {}, @@ -384,7 +386,9 @@ var elementVal = Wicket.$(elementId).value; var hasMinimumLength = elementVal.length >= minInputLength; var result = hasMinimumLength && activeIsInitial; - if (!result) hideAutoComplete(); + if (!result) { + hideAutoComplete(); + } return result; }], ep: {}, http://git-wip-us.apache.org/repos/asf/wicket/blob/599168c8/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js ---------------------------------------------------------------------- diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js index 9cdfb9e..b1defb5 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js @@ -19,7 +19,7 @@ 'use strict'; if (typeof(Wicket) === "undefined") { - Wicket = {}; + window.Wicket = {}; } Wicket.WUPB = Wicket.Class.create();
