[ 
https://issues.apache.org/jira/browse/WICKET-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14157270#comment-14157270
 ] 

ASF GitHub Bot commented on WICKET-5717:
----------------------------------------

GitHub user gsmet opened a pull request:

    https://github.com/apache/wicket/pull/78

    WICKET-5717 Support fragment in Url parse and toString

    Note: this PR is for the wicket-6.x branch.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/openwide-java/wicket support-fragment-in-url

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/wicket/pull/78.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #78
    
----
commit f35ae4303333ee741ca7dd517ed09647d1a28a1f
Author: Guillaume Smet <guillaume.s...@gmail.com>
Date:   2014-09-30T23:42:27Z

    WICKET-5717 Support fragment in Url parse and toString

----


> Url.parse/toString should support fragment
> ------------------------------------------
>
>                 Key: WICKET-5717
>                 URL: https://issues.apache.org/jira/browse/WICKET-5717
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.17.0
>            Reporter: Guillaume Smet
>         Attachments: redirect-url-anchor.tar.gz
>
>
> Hi,
> Starting with Wicket 6.16, we have issues redirecting to an absolute
> URL containing a fragment: the # is escaped by Wicket.
> Changes in the commit
> https://fisheye6.atlassian.com/changelog/wicket-git?cs=e1f29e90ff3a35e117bb3ddc5ee2aefd900c13c8
> are causing the regression but as far as we can see, the commit is not
> the problem: the issue is that Url.parse then toString encodes the
> anchor.
> Before this commit, as we were using an absolute Url, we were in the
> case where the Url wasn't escaped.
> We think the right fix would be to make org.apache.wicket.request.Url
> anchor aware.
> Pull request to come.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to